fix: concurrent access may cause an java.lang.ClassCastException #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By chance I encountered in the Jadx log several java.lang.ClassCastException java.util.HashMap$Node cannot be cast to java.util.HashMap$TreeNode in
JNodeCache.makeFrom()
.Based on some research this can happen in case the HashMap is accesses concurrently.
This seem to happen very very rarely as I wasn't able to reproduce this Exception in my further tests.
Nevertheless one time if failed and therefore I would suggest to better to use a ConcurrentHashMap for the JNodeCache.