Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package name #1

Closed
overheadhunter opened this issue Apr 3, 2020 · 3 comments
Closed

Change package name #1

overheadhunter opened this issue Apr 3, 2020 · 3 comments
Assignees

Comments

@overheadhunter
Copy link
Contributor

de.skymatic.app isn't a good package name. Use de.skymatic.appbills or something similar.

@tobihagemann any ideas for a name? Maybe even for a product name? I consider appstore-reverse-charger only the working title.

@infeo
Copy link
Contributor

infeo commented Apr 4, 2020

I agree with you, the identifier should be more specific. Since this package contains the gui, i would rename it to de.skymatic.gui. But this is also quite generic.

Maybe the main class should be outsourced in an extra package? Then we can choose the name quite freely. This would also be beneficial in combination with the module system, since then really only the main class is accessible from the outside.

@overheadhunter
Copy link
Contributor Author

It is not the Skymatic GUI, is it?

Follow the vendor.product.component scheme.

I don't mind, if you add "gui" (even though I prefer vertically sliced package names), but please add an application name!

@infeo infeo closed this as completed in 0596941 Apr 6, 2020
@infeo
Copy link
Contributor

infeo commented Apr 6, 2020

For a good name we can open a new issue, right now i just renamed it to fit into the suggested scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants