Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spot] sky spot cancel does not interrupt PENDING or STARTING job #1146

Closed
Michaelvll opened this issue Sep 1, 2022 · 2 comments · Fixed by #1414 or #1433
Closed

[Spot] sky spot cancel does not interrupt PENDING or STARTING job #1146

Michaelvll opened this issue Sep 1, 2022 · 2 comments · Fixed by #1414 or #1433
Labels
enhancement New feature or request P0

Comments

@Michaelvll
Copy link
Collaborator

The current behavior of our code is that we will set the spot job status for PENDING jobs to STARTING first before setting it to CANCLLED, which can be a bit confusing.

@Michaelvll Michaelvll added the enhancement New feature or request label Oct 29, 2022
@Michaelvll Michaelvll changed the title [Spot] sky spot cancel -a will not set the PENDING spot jobs to CANCELLED [Spot] sky spot cancel does not interrupt PENDING or STARTING job Nov 14, 2022
@Michaelvll
Copy link
Collaborator Author

Our sky spot cancel does not interrupt the provisioning and setup of a spot cluster either:

It seems that the spot cancel command isn’t propagated immediately.

(base) MacBook-Pro-3:~ dementrock$ sky spot cancel 28
Cancelling managed spot jobs with IDs 28. Proceed? [Y/n]: y
I 11-14 05:44:43 spot_utils.py:149] Cancelling jobs 28.
Job with ID 28 is scheduled to be cancelled within 20 seconds.
but the job is still in STARTING state for a while (still in setup phase).

@romilbhardwaj
Copy link
Collaborator

Reopening with #1432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0
Projects
None yet
2 participants