Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Dataset Symlink Issue #394

Closed
michaelzhiluo opened this issue Feb 20, 2022 · 4 comments · Fixed by #431
Closed

[Storage] Dataset Symlink Issue #394

michaelzhiluo opened this issue Feb 20, 2022 · 4 comments · Fixed by #431
Assignees
Labels
enhancement New feature or request Initial-User-Issue

Comments

@michaelzhiluo
Copy link
Collaborator

Sky will not upload dataset/sync file mount IF the dataset path is a symlink to the actual dataset path.

@Michaelvll Michaelvll added the enhancement New feature or request label Feb 21, 2022
@romilbhardwaj
Copy link
Collaborator

Symlinks can be quite hairy - we can start by simply putting a warning in the documentation that users should not put symlinks in their workdir/mounts.

@gmittal
Copy link
Collaborator

gmittal commented Feb 22, 2022

Can we use os.path.islink to throw an exception/warning if a user puts a symlink in the mounts/workdir?

@michaelzhiluo
Copy link
Collaborator Author

The hard part is if the workdir is not symlinked, but a SUBDIRECTORY is symlinked. This is pretty nasty to fix.

@concretevitamin
Copy link
Member

aws/aws-cli#453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Initial-User-Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants