fix: styling of components #72
Conversation
| @@ -145,7 +145,11 @@ export class DiscordEmbed implements ComponentInterface { | |||
| <slot></slot> | |||
| </div> | |||
| <slot name="fields"></slot> | |||
| <div class={clsx('discord-embed-media', { 'discord-embed-media-video': Boolean(this.video) })}>{this.renderMedia()}</div> | |||
| {this.image || this.video ? ( | |||
There was a problem hiding this comment.
Does this execute as (this.image || this.video) ? (...) : null or as this.image || (this.video ? (...) : null)?
If ESLint doesn't complain, I think it might be worth to wrap the OR condition with parens.
There was a problem hiding this comment.
This executes as the former based on comparison operations.
Prettier does complain however, so I think we are on the safe side with this:
|
Devcontainer was not touched, I simply pulled out the settings and extensions so they are also applied when not using a container. Edit: |
There was a problem hiding this comment.
Other than this it LGTM.
Should note btw that before I can release it I need to dive into the lib again because before my holiday late march I was struggling with something that was broken, but I don't remember what it was. That's also why the latest version is 2.0.3-alpha.0, because yarn link was being a huge PITA at that time.
.vscode/extensions.json
Outdated
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Please remove this file and .vscode/settings.json. While they're not bad per se, it's just not something we really add in Skyra Project repos.
There was a problem hiding this comment.
Yeah, I can do that. I mentioned it briefly to @kyranet though, so maybe you can find some nice solution for this overall.
If I would have coded this with Codespaces, it would have used his .devcontainer settings and forced it on me this way
I only added it since there is stuff like import sorting in there, which is kind of a source changing thing and will cause a conflict when you would re-save the file having those options enabled on your local settings
There was a problem hiding this comment.
You're not wrong. So far this hasn't been an issue though, so for now lets just revert it.
There was a problem hiding this comment.
Removed all unrelated changes 👍
This fixes a whole slew of CSS styling issues to get closer to Discords design philosophy.
Edit: I also took the liberty of copying out the settings and extensions to their own settings.json and extensions.json since I don't use Docker/Containers/Codespaces to work on this.
closes #42
closes #43
Old:
New:
Old:
New:
Old:
New:
Old:
New:
Old:
New:
