Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override DOM.DEFAULT_BLOCK_TAG? #159

Closed
whather opened this issue Jul 2, 2014 · 8 comments
Closed

Override DOM.DEFAULT_BLOCK_TAG? #159

whather opened this issue Jul 2, 2014 · 8 comments
Labels

Comments

@whather
Copy link

whather commented Jul 2, 2014

We're using Quill to produce email HTML and seems like a lot of email clients (at least Gmail) have excessive padding on paragraph tags. Wrapping lines in a

instead of a

seems to be the fix.

Would be great to have the ability to override DOM.DEFAULT_BLOCK_TAG

@jhchen
Copy link
Member

jhchen commented Jul 2, 2014

I think Github comments might be hiding some of your input but are you trying to say using <div> instead of <p>?

@jhchen jhchen added the feature label Jul 2, 2014
@whather
Copy link
Author

whather commented Jul 2, 2014

Oh whoops, yeah they stripped them out.

Yeah wrapping in div's instead of p's

@tdharris
Copy link

We're also using Quill to produce email HTML and getting paragraph spacing where we don't want any. Something to consider, in Microsoft Word - when you hit [Enter] it does presume a new paragraph is wanted (paragraph spacing is applied). When you hit [Shift] + [Enter] - it does not create a new paragraph and simply creates a line-break. This keeps the text all contained within a single paragraph.

In Quill, there is no way to visually see a representation of the spacing that is generated from the "p" tag. For example, the editor may show:
Here is text on one line
and text on a newline

But, in reality getHTML translates this into:

Here is text on one line

and text on a new line

Essentially, the problem I see is that there is paragraph spacing when just a "br" is wanted. So same thing in regards to the first comment. Just thought I'd explain how I see it.

@jhchen
Copy link
Member

jhchen commented Jul 22, 2014

Quill originally used a <div> but switched to <p> for semantic correctness but since it's causing issues we'll switch back in the next release.

@jhchen jhchen closed this as completed in a886370 Jul 22, 2014
@EmilStenstrom
Copy link

I fully agree with @tdharris here, supporting shift + enter should be a a priority. If you want to use div, that's fine, but <div>text</div><div>text</div> should be output with an enter, and <div>text<br>text</div> with shift + enter.

Should I start a new issue with this or is this one a good place to track this feature suggestion?

@jhchen
Copy link
Member

jhchen commented Nov 14, 2014

Should be a separate issue I think.

@EmilStenstrom
Copy link

@tdharris I've made a separate issue to track the shift + enter requirement: #252

@pmarreck
Copy link

pmarreck commented Dec 6, 2017

Quill is still using p tags when you hit Return in an editor, and it's (still) messing up my attempts to have people edit an html email signature (due to the aforementioned issues)... what's the deal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants