Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] As of 0.18.0 quill.getText(start, end) returns incorrect text range #236

Closed
bjnsn opened this issue Oct 23, 2014 · 1 comment
Closed

Comments

@bjnsn
Copy link

bjnsn commented Oct 23, 2014

This appears to be the result of the switch from tandem-core to rich-text. Also, it only occurs when formatting has been applied to the quill text.

This example (using 0.17.6) works as expected: http://jsfiddle.net/2d7z6Lft/1/
This example (using 0.18.1) does not: http://jsfiddle.net/2d7z6Lft/

Under the hood, this is currently relying on Delta.slice(start, end) - perhaps that is where the error is?

@jhchen
Copy link
Member

jhchen commented Oct 23, 2014

You're exactly right--there is a bug in rich-text delta's slice. Fix should be out in the next release.

@jhchen jhchen closed this as completed in 4ceb026 Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants