Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installer_options.state_verification to customize OAuth flow for admin's app installations #1101

Closed
6 of 13 tasks
seratch opened this issue Aug 31, 2021 · 1 comment · Fixed by #1116 or slackapi/node-slack-sdk#1339
Assignees
Labels
enhancement M-T: A feature request for new functionality
Milestone

Comments

@seratch
Copy link
Member

seratch commented Aug 31, 2021

Description

Having a state parameter in OAuth flow is a highly recommended practice for security in general. However, when Slack Enterprise Grid Org admins install an org-wide app from their app management page, there is no way to customize the slack.com authorize url.

Thus, to support the admins' use case, we can introduce a new option to disable state parameter validation in the OAuth flow. We are going to add flag options to App and AsyncApp plus modify the internal logic.

References:

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added the enhancement M-T: A feature request for new functionality label Aug 31, 2021
@seratch seratch added this to the 3.7.0 milestone Aug 31, 2021
@srajiang srajiang self-assigned this Aug 31, 2021
@seratch
Copy link
Member Author

seratch commented Sep 12, 2021

Releasing @slack/oauth@2.3.0 and upgrading the dependency in this project is required to fix this issue: https://github.com/slackapi/node-slack-sdk/milestone/27

@seratch seratch changed the title Add installer_options.state_validation to customize OAuth flow for admin's app installations Add installer_options.state_verification to customize OAuth flow for admin's app installations Sep 16, 2021
@srajiang srajiang reopened this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
2 participants