Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot use external-auth with x.com Provider via PKCE #371

Open
shoppingjaws opened this issue Oct 22, 2024 · 3 comments
Open

[BUG] Cannot use external-auth with x.com Provider via PKCE #371

shoppingjaws opened this issue Oct 22, 2024 · 3 comments
Labels
backend Slack backend issue question Further information is requested

Comments

@shoppingjaws
Copy link

shoppingjaws commented Oct 22, 2024

The deno-slack versions

Deno runtime version

deno 1.46.3 (stable, release, aarch64-apple-darwin)
v8 12.9.202.5-rusty
typescript 5.5.2

OS info

ProductName: macOS
ProductVersion: 14.2.1
BuildVersion: 23C71
Darwin Kernel Version 23.2.0: Wed Nov 15 21:59:33 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T811

Describe the bug

x.com oauth2.0 authentication has length limitation of the state query parameter of https://twitter.com/i/oauth2/authorize

https://developer.x.com/en/docs/authentication/oauth-2-0/authorization-code
image

But oauth2 privder from this sdk generates more than 500 characters state parameter.

Is there way to limit the length of state query parameter

Steps to reproduce

Expected result

Actual result

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@filmaj filmaj added question Further information is requested backend Slack backend issue labels Oct 22, 2024
@filmaj
Copy link
Contributor

filmaj commented Oct 22, 2024

I believe this would be a Slack backend issue, as the redirect to the provider is issued/generated by Slack and not specifically within this SDK. Does that sound correct to you?

If so, I can see about raising this internally.

@shoppingjaws
Copy link
Author

@filmaj Indeed, that's correct. 👍

@filmaj
Copy link
Contributor

filmaj commented Oct 22, 2024

Thanks, I have raised it internally and will report back what I find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Slack backend issue question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants