Special treatment for names and channels (@ and #)

[patcon]

Currently, using a designation that would be hyperlinked (#channel and @username) will send a nonsensical internal id to the bot. If this is simply a matter of providing special case where, if the hyperlinked text starts with @ or #, then use the link text and not the link url:

https://github.com/tinyspeck/hubot-slack/blob/master/src/slack.coffee#L78-L79

[evansolomon]

I don't think the issue here is the URL parsing. Names are mangled into internal ID's before the request is sent.

Any chance we could have those as plain text?

[grantmd]

I will unmangle in the internal code that sends to hubots.

[evansolomon]

Thanks @grantmd

[patcon]

Wooo! 👍

[grantmd]

Released. Hopefully made 100% better and 0% worse.

[evansolomon]

@grantmd confirmed that usernames look delightfully unmangled for us

[patcon]

Wahoo! I shall share with the team!

[vinibaggio]

@grantmd thank you!

[patcon]

Ok, still having issues, should we re-open this issue to change how hubot-slack processes the @NAMEs?

https://www.evernote.com/shard/s27/sh/5a76ea20-e0e0-4468-a717-7fec572b2342/a6c4f9505bf6abff5847676958bae896

[grantmd]

Yeah, the @ is intentional, but I can remove it from hubot messages if you like.

[patcon]

Cool. If you have time, but I can also convert this to a PR later when I get some time

[anandkkpr]

thanks for your efforts @grantmd!!!
thanks for sharing and making me aware of this chain @patcon!!!

++ to all above^^!!