Update files.upload.v2 internals due to server-side improvements #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
filmaj
approved these changes
Oct 4, 2023
packages/web-api/src/methods.ts
Outdated
| @@ -1884,7 +1884,7 @@ interface FileUpload { | |||
|
|
|||
| export interface FilesUploadV2Arguments extends FileUploadV2, WebAPICallOptions, TokenOverridable { | |||
| file_uploads?: Omit<FileUploadV2, 'channel_id' | 'channels' | 'initial_comment' | 'thread_ts'>[]; | |||
| request_file_info?: boolean; | |||
| request_file_info?: boolean; // since v7, this flag is no longer used | |||
There was a problem hiding this comment.
Maybe we can add a JSdoc description to this parameter with the @deprecated tag, to make clear not to use this?
There was a problem hiding this comment.
Alternatively, since we plan on releasing this in a major version, we can drop this argument altogether.
There was a problem hiding this comment.
Thanks! Removing it may prevent smooth upgrade for many people, so I've added a deprecation comment for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the internals of files.upload.v2 method to eliminate
files.infoAPI calls, which are no longer necessary because the server-side now returns the same metadata as part offiles.completeUploadExternalAPI responses.See also:
Requirements (place an
xin each[ ])