You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Include custom retry handler for Slack 500s by default similar to how ConnectionErrorRetryHandler is included by default in the WebClient. I think this would be a good addition because as a developer using the slack sdk I'd expect this to be the default behavior to prevent transient Slack server errors from raising a SlackApiError 😄.
Category (place an x in each of the [ ])
slack_sdk.web.WebClient (sync/async) (Web API client)
Thanks a bunch for the feature request 🙇🏻 Always appreciate hearing real-world usage feature requests! I certainly agree that having the framework provide a retry handler would be an improvement.
Out of curiosity, when are you receiving 500 responses from the Slack API? Is it on specific API methods?
@digitalnomd Thanks for taking the time to share the idea! Adding a new built-in handler sounds fine for me too.
Are you accepting PRs for this change if I were to put one up?
We appreciate your contribution 🙌 One thing I wanted to ask is that we don't want to enable the retry handler by default. The 500 errors you occasionally encournter may be resolved when immediately retrying the same but in many situations, the internal server errors may continue for a while especially during Slack's outage.
So, in summary,
We can add it to the bulit-in ones (sync and async) but we should not add it to default_retry_handlers() and async_default_retry_handlers()
Include custom retry handler for Slack 500s by default similar to how
ConnectionErrorRetryHandler
is included by default in theWebClient
. I think this would be a good addition because as a developer using the slack sdk I'd expect this to be the default behavior to prevent transient Slack server errors from raising aSlackApiError
😄.Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
The text was updated successfully, but these errors were encountered: