Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #69 #140

Closed
wants to merge 3 commits into from
Closed

Fix for issue #69 #140

wants to merge 3 commits into from

Conversation

bjab
Copy link

@bjab bjab commented Nov 7, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. New functionality for producing whatsits.

Related Issues

e.g. Fixes #206 and closes #230

Test strategy

e.g. Add tests around whatsit production.

Copy link

@DEGoodmanWilson DEGoodmanWilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an initial comment: We need you to sign the CLA before we can accept this PR.

Also, can you add some documentation both above and in the docs describing your new features?

I'll update this once we've had a chance to look it over in more detail!

@Roach
Copy link
Contributor

Roach commented Feb 22, 2017

@bjab we've updated our CLA mechanism since this was posted. You can sign it with your github account, which is much easier. 👍

@Roach Roach self-assigned this Feb 22, 2017
@Roach Roach requested review from Roach and aoberoi February 22, 2017 23:28
@Roach
Copy link
Contributor

Roach commented Oct 4, 2017

Fixed by #167

@Roach Roach closed this Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants