Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new arguments to admin.users.list API method #1418

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 2, 2023

Summary

This pull request adds two newly added options to https://api.slack.com/methods/admin.users.list

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Nov 2, 2023
@seratch seratch added this to the 3.23.1 milestone Nov 2, 2023
@seratch seratch self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1418 (1e3dd36) into main (9967dc0) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   85.47%   85.43%   -0.05%     
==========================================
  Files         111      111              
  Lines       11857    11857              
==========================================
- Hits        10135    10130       -5     
- Misses       1722     1727       +5     
Files Coverage Δ
slack_sdk/web/async_client.py 81.94% <ø> (ø)
slack_sdk/web/client.py 83.13% <ø> (ø)
slack_sdk/web/legacy_client.py 82.88% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 2d592cd into slackapi:main Nov 2, 2023
10 checks passed
@seratch seratch deleted the admin_users_list branch November 2, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant