Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RichTextBlock to Block.parse() targets #1433

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 23, 2023

Summary

This pull request adds a missing change in #1431

(reported at #1431 (comment))

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Nov 23, 2023
@seratch seratch added this to the 3.25.1 milestone Nov 23, 2023
@seratch seratch self-assigned this Nov 23, 2023
@seratch seratch modified the milestones: 3.25.1, 3.26.0 Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06e55d1) 85.39% compared to head (b1e7e2b) 85.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.01%     
==========================================
  Files         111      111              
  Lines       12132    12134       +2     
==========================================
+ Hits        10360    10361       +1     
- Misses       1772     1773       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tj-smith47
Copy link

You are a saint @seratch 🙏🏼 I appreciate all your efforts!

@seratch seratch merged commit 639dc9a into slackapi:main Nov 23, 2023
10 checks passed
@seratch seratch deleted the block-parse branch November 23, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants