-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all possible fields for RichTextElementParts.Date #1536
Conversation
running validate script, will post result |
passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1536 +/- ##
==========================================
+ Coverage 84.93% 85.00% +0.06%
==========================================
Files 113 113
Lines 12498 12501 +3
==========================================
+ Hits 10615 10626 +11
+ Misses 1883 1875 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sending this PR! The changes already look good to me, but can you add this pattern to the existing unit test here? Doing so should resolve the codecov warning in CI builds.
f56f11c
to
243eb77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍
Thanks for adding the the unit tests to maintain the code coverage 💯
Summary
This PR resolves issue 1533
Testing
No coresponding test were found, but confirmed properties with reference
Category
/docs-src
(Documents, have you run./scripts/docs.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.