Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all possible fields for RichTextElementParts.Date #1536

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

srtaalej
Copy link
Contributor

@srtaalej srtaalej commented Aug 1, 2024

Summary

This PR resolves issue 1533

Testing

No coresponding test were found, but confirmed properties with reference

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@srtaalej srtaalej added enhancement M-T: A feature request for new functionality Version: 3x labels Aug 1, 2024
@srtaalej srtaalej added this to the 3.31.1 milestone Aug 1, 2024
@srtaalej srtaalej self-assigned this Aug 1, 2024
@srtaalej
Copy link
Contributor Author

srtaalej commented Aug 1, 2024

running validate script, will post result

@srtaalej
Copy link
Contributor Author

srtaalej commented Aug 1, 2024

running validate script, will post result

passed!

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (98950d9) to head (c2ce162).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1536      +/-   ##
==========================================
+ Coverage   84.93%   85.00%   +0.06%     
==========================================
  Files         113      113              
  Lines       12498    12501       +3     
==========================================
+ Hits        10615    10626      +11     
+ Misses       1883     1875       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending this PR! The changes already look good to me, but can you add this pattern to the existing unit test here? Doing so should resolve the codecov warning in CI builds.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍

Thanks for adding the the unit tests to maintain the code coverage 💯

@srtaalej srtaalej merged commit 1058da3 into main Aug 14, 2024
13 checks passed
@srtaalej srtaalej deleted the ale-fix-issue-1533 branch August 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support all possible fields for RichTextElementParts.Date
3 participants