-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added message threads to the docs #163
Conversation
Current coverage is 64.16% (diff: 100%)@@ master #163 diff @@
==========================================
Files 9 9
Lines 293 293
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 188 188
Misses 105 105
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
👃
👄
) | ||
|
||
|
||
By default, `reply_broadcast` is set to `False`. To indicate your reply is germane to all members of a channel, set the reply_broadcast boolean parameter to `True`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second use of "reply_broadcast" should be in single backticks?
|
||
|
||
When your reply is broadcast to the channel, it'll actually be a reference to your reply, not the reply itself. | ||
So, when appearing in the channel, it won't contain any attachments or message buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it have attachments and message buttons in-thread?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
* Added message threading to docs
PR Summary
Related Issues
✅ I've read and understood the Contributing guidelines and have done my best effort to follow them.
✅ I've read and agree to the Code of Conduct.
✅ I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
✅ I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
✅ I've written tests to cover the new code and functionality included in this PR.
✅ I've read, agree to, and signed the Contributor License Agreement (CLA).