Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.6 to testing #176

Merged
merged 4 commits into from
Jun 5, 2017
Merged

Add Python 3.6 to testing #176

merged 4 commits into from
Jun 5, 2017

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 3, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. New functionality for producing whatsits.

Related Issues

e.g. Fixes #206 and closes #230

Test strategy

e.g. Add tests around whatsit production.

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 3, 2017

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files           9        9           
  Lines         293      293           
=======================================
  Hits          188      188           
  Misses        105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0ad91...2600d02. Read the comment docs.

@cclauss cclauss changed the title Patch 8 Add Python 3.6 to testing Apr 3, 2017
@Roach Roach merged commit 8386a0b into slackapi:master Jun 5, 2017
@Roach
Copy link
Contributor

Roach commented Jun 5, 2017

Thanks, @cclauss 👍

@cclauss cclauss deleted the patch-8 branch June 6, 2017 03:49
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
* Add Python 3.6 to testing

* Add Python 3.6 to testing

* dist: trusty

* python:   - "3.6"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants