-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of custom parameters on rtm_connect() #210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 59.67% 59.61% -0.07%
==========================================
Files 9 9
Lines 310 312 +2
Branches 57 57
==========================================
+ Hits 185 186 +1
- Misses 111 112 +1
Partials 14 14
Continue to review full report at Codecov.
|
thanks for the PR! i think these performance gains (and more) can be realized by the change in #209 by using the |
I think this is definitely a valuable change, and I'll be merging this as soon as I get #209 sorted. Ideally, We'd like to allow the developer to specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed merge conflicts with updated master
@kamushadenes can you sign the CLA real quick so I can merge this change? |
Guys, REALLY SORRY for the massive delay. I had a busy month and totally forgot to check GitHub. I signed the CLA now. |
* Update client.py * Update server.py * Update client.py * Update server.py
Summary
This PR allows the use of additional parameters on rtm_connect().
With this patch, when rtm_connect() is invoked like:
self.slack.rtm_connect(no_latest=True, no_unreads=True, presence_sub=True)
a huge performance improvement was seen in bot general responsiveness.
Requirements (place an
x
in each[ ]
)