Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of custom parameters on rtm_connect() #210

Merged
merged 5 commits into from
Sep 29, 2017

Conversation

kamushadenes
Copy link
Contributor

Summary

This PR allows the use of additional parameters on rtm_connect().

With this patch, when rtm_connect() is invoked like:

self.slack.rtm_connect(no_latest=True, no_unreads=True, presence_sub=True)

a huge performance improvement was seen in bot general responsiveness.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #210 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   59.67%   59.61%   -0.07%     
==========================================
  Files           9        9              
  Lines         310      312       +2     
  Branches       57       57              
==========================================
+ Hits          185      186       +1     
- Misses        111      112       +1     
  Partials       14       14
Impacted Files Coverage Δ
slackclient/server.py 59.05% <100%> (ø) ⬆️
slackclient/client.py 37.93% <50%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8f0ba...4f9b28f. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Aug 22, 2017

thanks for the PR! i think these performance gains (and more) can be realized by the change in #209 by using the rtm.connect Web API method. i still like this idea because it will allow developers to be more specific about which tradeoffs they need. i'd like to see this land, but i also want to hear what @Roach has to say about it.

@aoberoi aoberoi requested a review from Roach August 22, 2017 19:00
@Roach
Copy link
Contributor

Roach commented Aug 23, 2017

I think this is definitely a valuable change, and I'll be merging this as soon as I get #209 sorted. Ideally, We'd like to allow the developer to specify rtm.start or rtm.connect and pass these vars into that call to provide additional configurability. 👍

Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed merge conflicts with updated master

@Roach
Copy link
Contributor

Roach commented Aug 31, 2017

@kamushadenes can you sign the CLA real quick so I can merge this change?
https://cla-assistant.io/slackapi/python-slackclient?pullRequest=210

@kamushadenes
Copy link
Contributor Author

Guys, REALLY SORRY for the massive delay.

I had a busy month and totally forgot to check GitHub.

I signed the CLA now.

@Roach Roach merged commit ffc6e00 into slackapi:master Sep 29, 2017
@Roach Roach mentioned this pull request Nov 22, 2017
2 tasks
@Roach Roach added this to the 1.x milestone Dec 2, 2017
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
* Update client.py

* Update server.py

* Update client.py

* Update server.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants