Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link Button #567

Closed
wants to merge 2 commits into from
Closed

Fix Link Button #567

wants to merge 2 commits into from

Conversation

zpriddy
Copy link

@zpriddy zpriddy commented Nov 18, 2019

Button requires a string for value. To fix this use the same random_id as the action id

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

Button requires a string for value. To fix this use the same random_id as the action id
Update test to match change to LinkButtonElement
@pedromcaraujo
Copy link
Contributor

Hi @zpriddy. This seems like the same problem as #563.

@zpriddy
Copy link
Author

zpriddy commented Nov 18, 2019

@pedroma - Didnt see that one. Thanks!

@zpriddy zpriddy closed this Nov 18, 2019
@pedromcaraujo
Copy link
Contributor

pedromcaraujo commented Nov 18, 2019 via email

@pedromcaraujo
Copy link
Contributor

If the people at Slack prefer this approach it's totally ok. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants