Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #672 files.upload fails with a filepath containing multi byte chars #673

Merged
merged 2 commits into from
May 11, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 8, 2020

Summary

This pull request fixes #672 by changing the way to handle a local file path when uploading a file to the Slack server.

In addition, I've applied a minor improvement to use the local file name when the filename parameter is not given (currently this library set "file" for such cases).

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client v2.6 in-progress labels May 8, 2020
@seratch seratch added this to the 2.6.0 milestone May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #673 into master will decrease coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   87.17%   87.08%   -0.09%     
==========================================
  Files          15       15              
  Lines        1824     1827       +3     
  Branches      100      101       +1     
==========================================
+ Hits         1590     1591       +1     
- Misses        202      204       +2     
  Partials       32       32              
Impacted Files Coverage Δ
slack/web/client.py 96.46% <33.33%> (-0.38%) ⬇️
slack/web/base_client.py 79.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1247588...86b82af. Read the comment docs.

@seratch seratch merged commit 15581e8 into slackapi:master May 11, 2020
@seratch seratch deleted the issue-672 branch May 11, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File with multi-byte characters in the filename can not be uploaded.
2 participants