-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP RetainedStateHolder #1168
Draft
ZacSweers
wants to merge
12
commits into
main
Choose a base branch
from
z/stateInTabs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP RetainedStateHolder #1168
+636
−38
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e428463 - Browse repository at this point
Copy the full SHA e428463View commit details -
This is just some tinkering to resolve #116 and after talking with @bryanstern. Wanna iterate on this more and see if we can make this simpler, and also possibly explore implementing an analogous `RetainedStateHolder`. Another thing this highlights is the fact that we always initially show a progress indicator even when restoring from a loaded state, wonder what we can do to improve that.
Configuration menu - View commit details
-
Copy full SHA for a8544ae - Browse repository at this point
Copy the full SHA a8544aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13622e9 - Browse repository at this point
Copy the full SHA 13622e9View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 920299b - Browse repository at this point
Copy the full SHA 920299bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dca28da - Browse repository at this point
Copy the full SHA dca28daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73d98bd - Browse repository at this point
Copy the full SHA 73d98bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21b0e15 - Browse repository at this point
Copy the full SHA 21b0e15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 068c1a8 - Browse repository at this point
Copy the full SHA 068c1a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70a1512 - Browse repository at this point
Copy the full SHA 70a1512View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2d0e16 - Browse repository at this point
Copy the full SHA b2d0e16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 924ecab - Browse repository at this point
Copy the full SHA 924ecabView commit details
Commits on Mar 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 848ca4e - Browse repository at this point
Copy the full SHA 848ca4eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.