Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control+click doesn't open in a new tab #317

Closed
rightfold opened this issue Aug 5, 2015 · 3 comments
Closed

Control+click doesn't open in a new tab #317

rightfold opened this issue Aug 5, 2015 · 3 comments
Labels
enhancement toc

Comments

@rightfold
Copy link

On normal web pages with normal navigation, control+click normally opens the target in a new tab. In Slate it doesn't. (Incredible solution: use normal hyperlinks.)
@lord lord added this to the Version 2 milestone Aug 5, 2015
@lord
Copy link
Member

lord commented Aug 5, 2015

We used tocify in the past, which is why they aren't <a>s. In v2 we're moving away from tocify, so I'll be sure that this works — I agree that this is annoying!

@rightfold
Copy link
Author

I love you! <3

@lord lord removed this from the Version 2 milestone Jan 26, 2016
@lord lord added the toc label Jan 27, 2016
@lord lord added this to the Version 1.3 milestone Jan 27, 2016
@lord lord removed this from the Version 1.4 milestone Feb 24, 2017
@lord lord mentioned this issue Feb 24, 2017
Merged
8 tasks
@lord
Copy link
Member

lord commented Feb 24, 2017 •
edited
Loading

The new tab problem should be fixed in the latest dev branch — we've switched to using normal <a> tags! LMK if you run into any issues, I'd definitely love to know.

@lord lord closed this as completed Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement toc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lord @rightfold