Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically generate ToC and Sections #45

Closed
lord opened this issue Apr 20, 2014 · 5 comments
Closed

Statically generate ToC and Sections #45

lord opened this issue Apr 20, 2014 · 5 comments

Comments

@lord
Copy link
Member

lord commented Apr 20, 2014

We're hosting static content, so we should be able to create the table of contents and <section>s before sending it to the user. This probably also involves removing Tocify.

Also #551 mentions preserving italics, which is a good idea.

realityking referenced this issue in realityking/slate Feb 14, 2015
realityking referenced this issue in realityking/slate Feb 16, 2015
realityking referenced this issue in realityking/slate Mar 29, 2015
realityking referenced this issue in realityking/slate May 31, 2015
@lord lord added this to the Version 2 milestone Jun 20, 2015
ketan referenced this issue in ketan/api.go.cd Oct 17, 2015
@lord lord modified the milestones: Version 2, Version 2.0 Jan 26, 2016
@lord lord added the toc label Jan 27, 2016
@seweil
Copy link

seweil commented Nov 30, 2016

Yes, building the TOC DOM dynamically appears to take about 40% of page load time.
Another possible approach is to save the TOC from the browser at 'build' time.

@PreciselyAlyss
Copy link

Going through the V2 feature branch, it seems that it only headers are only identified if they are used in the index page and not if they are within the included files. Is there a good way to be able to read the headers out of included files or is this a limitation of that current feature implementation?

@lord lord removed this from the Version 1.4 milestone Feb 24, 2017
@lord lord mentioned this issue Feb 24, 2017
8 tasks
@lord
Copy link
Member Author

lord commented Feb 24, 2017

Added in the dev branch! Let me know if anybody runs into issues with the new code.

@bc-AlyssNoland thanks for the catch, this should be fixed in the latest toc generation implementation!

@lord lord closed this as completed Feb 24, 2017
evilstickman referenced this issue in evilstickman/slate Mar 1, 2017
Removed problematic whitespace
@seweil
Copy link

seweil commented Apr 28, 2017

@lord - If we want to try static TOC, would you recommend that we apply #701 to the release branch, or run with the dev branch? (E.g. can you comment on completeness and stability?)

@lord
Copy link
Member Author

lord commented Apr 29, 2017

@seweil I'd try out the dev branch! There may be a few remaining bugs with it, but applying #701 to the release branch would result in the same bugs or maybe even more.

aaronbasdeo referenced this issue in aaronbasdeo/slate Mar 12, 2020
luniki referenced this issue in luniki/docs-studip-plugin-jsonapi Jun 23, 2020
desandi referenced this issue in FocusNFe/api-doc Oct 5, 2023
Update _comunicador-focus-nfe.md.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants