Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that ACLs are Enabled #110

Open
eamallory72 opened this issue Jul 28, 2022 · 2 comments
Open

Check that ACLs are Enabled #110

eamallory72 opened this issue Jul 28, 2022 · 2 comments

Comments

@eamallory72
Copy link

eamallory72 commented Jul 28, 2022

Hello,
I extended your script to check if a particular ACL is enabled. Specifically the Deny_All acl. When we update the firmware in our ADC cluster the Deny_All gets automatically removed and the admin sometimes forgets to replace it.
The code below starts on line 366
just below the elsif ($plugin->opts->objecttype eq 'server') stanza.

} elsif ($plugin->opts->objecttype eq 'nsacl') {
$params{'endpoint'} = $plugin->opts->endpoint || 'config';
$field_name = 'aclname';
$field_state = 'state';
$enable_perfdata = 0;

We're using version Version: v1.4.0 (2017-08-20)
We should probably upgrade. :)
Hope you find this useful.
Thanks,
Erik Mallory

@eamallory72
Copy link
Author

In the current version this edit should occur on line 439 should you choose to include it.
Thanks,
Erik

@slauger
Copy link
Owner

slauger commented Jul 31, 2022

Hey @eamallory72,

thanks for your message, but isn't this already be possible with the existing checks? Maybe with matches/matches_not? Or do i get something wrong?

Also it sounds like that your use case is very specific. I don't know if it makes sense to implement this for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants