-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1.7, 2.1.8, Git master
] Plugin smartpause
calls disable_safeeyes
with unsupported signature, causing display of a backtrace
#580
Comments
smartpause
calls disable_safeeyes
with unsupported signature, causing display of a backtracemaster
] Plugin smartpause
calls disable_safeeyes
with unsupported signature, causing display of a backtrace
Is this issue present in releases with python 3.12? Or is it python version independent. For maximum stability, I am planning to only include the new version of safe eyes (2.1.8 or later) for Ubuntu 24.04 or later. For previous versions of Ubuntu, Safe Eyes is already available on the official repositories. |
How to reproduce this crash? |
I ran
I am using KDE 5.27 with Wayland. |
This needs to be tested on either GNOME or Sway Wayland, or on X11 - KDE Wayland currently does not support smartpause at all, really. (It uses xprintidle, which ends up always being idle, effectively.) (The message about |
@archisman-panigrahi quoting myself from above:
The smartpause plug-in needs to be enabled of course. And I think not doing anything else in that time helps if the plugin wants to disable SafeEyes only when the machine is idle. My understanding of the plugin is superficial at the moment, though. |
@deltragon cool, thank you! |
I have a fix up in #582. It would be good if you could test it, and confirm it resolves the issue. |
Sorry for creating the problem and not responding earlier. I have only just found time to come back to safeeyes and I'm glad that someone has fixed it many thanks. |
Describe the bug
I witnessed this backtrace at runtime:
The suppose cause is that code…
SafeEyes/safeeyes/safeeyes.py
Lines 74 to 75 in 5cd9b8a
…only supports a single argument while…
SafeEyes/safeeyes/safeeyes.py
Line 242 in 5cd9b8a
…supports more.
Could be a regression from commit 903d407 .
CC @AdamPS
To Reproduce
Steps to reproduce the behavior:
safeeyes
from the terminalExpected behavior
No backtrace
Desktop (please complete the following information):
Debug Log
n/a
Screenshots
n/a
The text was updated successfully, but these errors were encountered: