Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Provides psr-17" in composer #163

Closed
webmaster777 opened this issue Jul 28, 2020 · 1 comment · Fixed by #164
Closed

"Provides psr-17" in composer #163

webmaster777 opened this issue Jul 28, 2020 · 1 comment · Fixed by #164

Comments

@webmaster777
Copy link
Contributor

webmaster777 commented Jul 28, 2020 •
edited
Loading

The library provides all required PSR-17 interfaces. Shouldn't it be able to add "psr/http-factory-implementation": "1.0" to the provide key in composer.json?

Just like Guzzle and Diactoros do. See https://packagist.org/providers/psr/http-factory-implementation.

I want to use a library that requires psr/http-factory-implementation ^1.0 and I want to use this package.
@danopz
Copy link
Member

danopz commented Jul 28, 2020

Thought I added it back then in #17 but looks like I somehow forgot that one. Just go ahead and create a PR I would say 😃

@webmaster777 webmaster777 mentioned this issue Aug 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provide PSR-17 implementation (composer)
2 participants
@danopz @webmaster777