From 303347fd5296e3dff9104d023bfb0878ff494989 Mon Sep 17 00:00:00 2001
From: Tobias Hunger <tobias.hunger@slint.dev>
Date: Sun, 30 Jun 2024 17:50:24 +0200
Subject: [PATCH] compiler: Fix bug in snapshotting

Do not `take` an ElementRc to move it into the `Component`'s `root_element`.

@ogoffart spotted this! Thanks!
---
 internal/compiler/typeloader.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/internal/compiler/typeloader.rs b/internal/compiler/typeloader.rs
index c61f9d4d394..868acee3a16 100644
--- a/internal/compiler/typeloader.rs
+++ b/internal/compiler/typeloader.rs
@@ -212,15 +212,16 @@ impl Snapshotter {
         } else {
             std::rc::Weak::default()
         };
+
         let r = Rc::new(object_tree::Component {
             node: component.node.clone(),
             id: component.id.clone(),
             parent_element,
+            root_element: self.snapshot_element(&component.root_element),
             ..Default::default()
         });
         self.component_map.insert(by_address::ByAddress(component.clone()), r.clone());
 
-        let root_element = self.snapshot_element(&component.root_element);
         let optimized_elements = component
             .optimized_elements
             .borrow()
@@ -247,7 +248,6 @@ impl Snapshotter {
         r.inherits_popup_window.set(component.inherits_popup_window.get());
         *r.exported_global_names.borrow_mut() = component.exported_global_names.borrow().clone();
         *r.private_properties.borrow_mut() = component.private_properties.borrow().clone();
-        *r.root_element.borrow_mut() = root_element.take();
         *r.child_insertion_point.borrow_mut() = child_insertion_point;
         *r.popup_windows.borrow_mut() = popup_windows;