Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode live-preview can lead to crashing Desktop Enviroment #782

Closed
Vollbrecht opened this issue Jan 2, 2022 · 2 comments
Closed

VSCode live-preview can lead to crashing Desktop Enviroment #782

Vollbrecht opened this issue Jan 2, 2022 · 2 comments
Labels
a:layouts Related to the layouting and positioning of the elements (mO,bT) bug Something isn't working duplicate This issue or pull request already exists

Comments

@Vollbrecht
Copy link
Contributor

Description

Live editing "width" values with relative length can lead to uncontrollable window growth. This uncontrollable growth crashes Gnome on Debian

Expectation

Arbitrary Values in width / height should not crate a situation (on live edit) that gets uncontrollable.

Behavior

Typing the wrong value on edit leads to an instantaneous not responsible DE.
Example that creates the issue.


export AppWindow := Window {
    VerticalBox{
        HorizontalLayout {
            alignment: end;
            Rectangle {
                width: parent.width * 80%; 
                horizontal-stretch: 0.2;
             }
            GridLayout {
                width: parent.width * 20%;
                horizontal-stretch:0.2;
                Row {
                    Button {
                        width: 80px;
                        height: 80px;
                                ....
                        }
                    }                  
                 
            }
        }
    }
}

Software version

sixtyfps master/ 75ba29c
sixtyfps-vscode nightly v2021.12.2818

Operating System

Linux 5.10.0-8-amd64 -- Debian11

DE

GNOME 3.38.6

@ogoffart
Copy link
Member

ogoffart commented Jan 2, 2022

I have noticed such problems myself before.
I'm not sure how to mitigate them. Maybe limmiting the window size to some value?
Or detecting the binding loop in this case even if that's technicly not a binding loop?

@ogoffart ogoffart added the a:layouts Related to the layouting and positioning of the elements (mO,bT) label Jul 13, 2023
@ogoffart
Copy link
Member

This is fixed for the live preview since we have a new UI.
Although the root cause is still there, but tracked in #2902

@ogoffart ogoffart added bug Something isn't working duplicate This issue or pull request already exists labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:layouts Related to the layouting and positioning of the elements (mO,bT) bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants