Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border around ScrollView native widget #824

Closed
jrmoulton opened this issue Jan 10, 2022 · 7 comments
Closed

Border around ScrollView native widget #824

jrmoulton opened this issue Jan 10, 2022 · 7 comments
Labels
a:widgets Implementation of widgets (from std-widgets.slint) and their styles (mF,bS)

Comments

@jrmoulton
Copy link
Contributor

https://github.com/sixtyfpsui/sixtyfps/blob/ce7a13b70d0a4be183626a234834251e62046589/sixtyfps_runtime/rendering_backends/qt/qt_widgets/scrollview.rs#L270

This section of code and it's references create a black border around a ScrollView that becomes obvious and distracting and non-removable when it's x or y are set inside the window. Why does this border exist? If I delete this section of code and its references everything compiles fine and the ScrollView looks much better in my opinion without the distracting border. Why is that border created by default?

@jrmoulton
Copy link
Contributor Author

Screen Shot 2022-01-09 at 10 05 18 PM

vs.

Screen Shot 2022-01-09 at 10 05 05 PM

@ogoffart
Copy link
Member

It depends on the QStyle used. For some QStyle it might be required.
But there is definitively something wrong. Looks like we should draw this differently. As this is a problem for this style.
What desktop environment are you using? Is that Gnome? Do you know if Qt is using the GTK style? Is it Qt5 or Qt6 ?

@jrmoulton
Copy link
Contributor Author

I'm currently on macOS and I'm running Qt6

@dilawar
Copy link

dilawar commented Jun 13, 2022

I also agree with @jrmoulton. I also don't like border around ScrollView and ListView. Is there a simple way to disable the border? I am on Windows + Rust, and using defaults.

image

@dilawar
Copy link

dilawar commented Jun 13, 2022

Setting border-width : 0px for ScrollView removed the border for me. I feel dumb for not trying the first obvious thing before commenting here 😳.

@ogoffart
Copy link
Member

Perhaps this is related to #686 ?

@ogoffart ogoffart added the a:widgets Implementation of widgets (from std-widgets.slint) and their styles (mF,bS) label Jun 28, 2023
@tronical
Copy link
Member

As discussed with Florian, this does not seem relevant anymore - with QStyle not being used on macOS and Windows anymore, and the ability to set the border-width manually.

@tronical tronical closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:widgets Implementation of widgets (from std-widgets.slint) and their styles (mF,bS)
Projects
None yet
Development

No branches or pull requests

4 participants