New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalLoggerGuard should implement Debug #246

Open

Diggsey opened this issue Nov 22, 2019 · 1 comment

Labels

C-enhancement P-low

Diggsey commented Nov 22, 2019

All public types should implement Debug unless there's a good reason not to.

Since the guard removes the logger when it is dropped, it can be necessary to store the guard as part of a struct which may have Debug bounds.

Collaborator

dpc commented Nov 22, 2019

PR, pls. Thx!

Techcable added C-enhancement P-low labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment