From a1886c94dbebb0ab34f1e9f44d489862f4f72093 Mon Sep 17 00:00:00 2001 From: Techcable Date: Tue, 22 Mar 2022 22:52:30 -0700 Subject: [PATCH] Don't test log/unstable_kv feature on the MSRV Due to its unstable feature, it requires a recent compiler and we cannot reasonably make MSRV guarentees for their project. Add disclaimer about this to the Cargo.toml file --- .github/workflows/test.yml | 6 ++++++ Cargo.toml | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2d7bca6..03d86e1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,6 +29,9 @@ jobs: fail-fast: false # Even if one job fails we still want to see the other ones matrix: # 1.39 is MSRV. Keep in sync with Cargo.toml + # + # There are no MSRV guarentees for the kv_unstable feature. + # See `Cargo.toml` for more details. rust: [1.39, stable, nightly] # NOTE: Features to test must be specified manually. They are applied to all versions seperately. # @@ -37,6 +40,9 @@ jobs: # # Specific feature combos can be overriden per-version with 'include' and 'exclude' features: ["", "kv_unstable"] + exclude: + - rust: 1.39 # MSRV (see above) + features: "kv_unstable" steps: - uses: actions/checkout@v2 diff --git a/Cargo.toml b/Cargo.toml index 645f3d4..9b5b576 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -21,6 +21,10 @@ edition = "2018" # # The first version of Cargo that supports this field was in Rust 1.56.0. # In older releases, the field will be ignored, and Cargo will display a warning. +# +# DISCLAIMER: +# The log/kv_unstable feature requires a recent (stable) compiler. +# It will not compile with this claimed MSRV and requires a recent (stable) compiler. rust-version = "1.38" [lib]