Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVD implementation is based on GPL code #71

Open
osidorkin opened this issue Feb 3, 2016 · 1 comment
Open

SVD implementation is based on GPL code #71

osidorkin opened this issue Feb 3, 2016 · 1 comment

Comments

@osidorkin
Copy link

svd.js code is based on Python SVD implementation which is licensed under GPL license:
https://github.com/sloisel/numeric/blob/master/src/svd.js
http://stitchpanorama.sourceforge.net/Python/svd.py

Following GPL license terms numeric.js should be released under GPL license as well so MIT license is incorrect.

Could you please check this legal issue?
Possible solution can be to make SVD part optional and released under GPL.

@mitar
Copy link

mitar commented Dec 4, 2016

But that Python SVD implementation is based on an algorithm:

Almost exact translation of the ALGOL SVD algorithm published in Numer. Math. 14, 403-420 (1970) by G. H. Golub and C. Reinsch

So one could argue that both this and Python code is just code translation of the algorithm from the book and as such are not really enough new contribution to be even copyrightable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants