Add a rightclick handler for map interaction #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: works for gnomic and polar projections Still missing calling the callback on long touch
The previous code was redrawing for each event. Meaning if the browser send 1 events every 10ms, virtualsky must be able to draw in 10ms or less to keep smooth. A small delay is introduced (20ms), so accumulated events can be dequeued between redraws.
|
Good work pludov. I'd almost be tempted to do some of this through a plugin to keep the main file size down for those who don't need a context menu. |
|
Having said that... I've just seen your comment on #25 (comment) and you are right that it solves that. |
|
@pludov Would you object to me renaming the |
|
No objection on my side !
Le 6 août 2019 14:54:19 GMT+02:00, Stuart Lowe <notifications@github.com> a écrit :
…
@pludov Would you object to me renaming the `rightclick` event as
`contextmenu` just to keep it matching with
https://developer.mozilla.org/en-US/docs/Web/API/Element/contextmenu_event
?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#58 (comment)
--
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.
|
|
OK. I've made some changes and cleaned up the code a bit using jshint.com. Thanks for all your contributions @pludov! Make sure to update before making more changes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a callback to get notified for right click in the map. The callback will receive an event object including the location of the click (RA, DEC) and the id of the closest marker if present.
This partially resolves issue #25 since it provides RA and DEC in the callback.