Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for special handling of material verification for npm #524

Closed
laurentsimon opened this issue Mar 9, 2023 · 7 comments
Labels
area:npm An issue with verification of npm packages type:feature New feature request

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Mar 9, 2023

See #521 (comment)

@ianlewis
Copy link
Member

I suppose we may want to be able to verify provenance generated during the public beta. So maybe we can check if it's been generated as of a certain date so that we can check this for provenance generated after the GA?

@laurentsimon
Copy link
Contributor Author

This should work, good idea.

@asraa
Copy link
Contributor

asraa commented Mar 10, 2023

Or maybe there's a versioning in their buildType or something else to identify stable format?

@ianlewis ianlewis added type:feature New feature request area:npm An issue with verification of npm packages labels Mar 16, 2023
@ianlewis
Copy link
Member

Or maybe there's a versioning in their buildType or something else to identify stable format?

That's maybe an even better idea.

@laurentsimon
Copy link
Contributor Author

Last time we talk they did not have, ie it was tied to the CLI version. But I think they will change that, so need to follow-up

@ianlewis
Copy link
Member

This will get fixed by #641

@ramonpetgrave64
Copy link
Contributor

#641 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:npm An issue with verification of npm packages type:feature New feature request
Projects
None yet
Development

No branches or pull requests

4 participants