Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Update retrieval of workflow #611

Closed
laurentsimon opened this issue May 23, 2023 · 2 comments · Fixed by #615
Closed

[feature] Update retrieval of workflow #611

laurentsimon opened this issue May 23, 2023 · 2 comments · Fixed by #615
Labels
specs:v1.0
Milestone
BYOB

Comments

@laurentsimon
Copy link
Contributor

The workflow parameters in v1.0 is currently stored in externalParameters, but we're changing that to under internalParameter. We need to update the verification routine
@laurentsimon laurentsimon added this to the BYOB milestone May 23, 2023
@laurentsimon laurentsimon mentioned this issue May 23, 2023
Closed
@laurentsimon
Copy link
Contributor Author

One complication is that depending on the builder (builder vs generator), the workflow will be either in the externalParameters or in the internalParameters. I think this means we'll need to retrieve the workflow information differently based on builder "type" (GH-runner vs re-usable workflow).

Not sure yet where the best place is to encode this information.

@laurentsimon
Copy link
Contributor Author

I've decided to tackle the builder part first. I created #613 for tracking generator support

@laurentsimon laurentsimon mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
specs:v1.0
Projects
None yet
Milestone
BYOB
Development

Successfully merging a pull request may close this issue.

feat: Use env variable to retrieve trigger workflow laurentsimon/slsa-verifier
1 participant
@laurentsimon