-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes and more #24
Conversation
needs slub/ocrd_manager#57 |
@SvenMarcus to implement this, we would need to "log in" to the Manager and kill the given process ID. But I don't like the Monitor to hold the keys. Perhaps we should instead start implementing our minimalistic web server in the Manager itself – delegating to Sry, I'll update the CI tests shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work thx!
With the test, we are currently running on the CI in an endless loop.
tests/ocrdmonitor/test_readlogs.py ..... [ 37%]
tests/ocrdmonitor/test_redirect.py ......... [ [53](https://github.com/slub/ocrd_monitor/actions/runs/4677162691/jobs/8284349346#step:5:54)%]
Error: The operation was canceled.
To me it looks like the tests/ocrdmonitor/test_sshps.py
is affected.
Possibly it is due to the changed SSH user, since the test itself was not adjusted.
@SvenMarcus What do you think?
All right thanks. When the |
…rdController class
Everything except naming of ProcessState should be resolved
process_id
must be a str not an int, esp. for process_mets.sh$REMOTEDIR/ocrd.pid
(on Controller), not from$PID
(on Manager)