Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE crashes if trying completion when cursor is on a string with space in front of it #26

Closed
hazratisulton opened this issue Jan 16, 2024 · 13 comments

Comments

@hazratisulton
Copy link

Steps to reproduce:
Add at least one space character on line
Try completion from start of line

Expected result:
IDE and completion working

Actual result:
After entering several characters and space character IDE crashes
https://github.com/smallcloudai/refact-vs-classic/assets/140423660/f86eb6a4-937d-410e-a573-61923159de30

Software versions:
Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.8.4
Refact plugin v 0.0.1 https://github.com/smallcloudai/refact-vs-classic/actions/runs/7469728225?pr=22
Windows 11 Pro 22H2 22621.2861

Logs:
rustbinary.zip
ActivityLog.zip

@digital-phoenix
Copy link
Contributor

Why is the server running in it's own window in your setup?

@digital-phoenix
Copy link
Contributor

digital-phoenix commented Jan 17, 2024

Make sure to uninstall any previous versions when installing the latest one because it doesn't look like you are running the correct version. The most up to date version would show a status bar icon and would not have the server running in a separate window.

@hazratisulton
Copy link
Author

Server isn't running separately. I just opened logs (..cache\refact\logs\rustbinary.2024-01-17) of refact-lsp server built into the plugin.
Uninstalled plugin, then installed plugin from https://github.com/smallcloudai/refact-vs-classic/actions/runs/7469728225.
https://github.com/smallcloudai/refact-vs-classic/assets/140423660/fec0eede-4e7a-496a-af02-4e61006aef44

@digital-phoenix
Copy link
Contributor

Looks like spaces isn't the trigger. Can you try typing one letter at a time and waiting for the completion before typing the next letter and see if it still crashes?

@digital-phoenix
Copy link
Contributor

What do you mean by space because your letter example includes spaces?

@hazratisulton
Copy link
Author

Try to reproduce this steps for IDE crash:
Create new file
Type a space character
Return to the beginning of the line
Type any characters, for example "def"
Type a space character
Wait for the fall
(If necessary, try typing one letter at a time and wait)

@digital-phoenix
Copy link
Contributor

This should be fixed in the latest pull request

@hazratisulton
Copy link
Author

@digital-phoenix
Copy link
Contributor

Is that only happening when you hit enter on a line with a space after the cursor?

@digital-phoenix
Copy link
Contributor

@hazratisulton are you on the company slack because I would like to communicate with you more broadly beyond this specific issue.

@digital-phoenix
Copy link
Contributor

@hazratisulton this should be fixed now

@hazratisulton
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants