VertxDynamicGraphQLClient

[hogmuzzle]

In RequestImpl

private JsonObject _formatJsonVariables() {
JsonObjectBuilder varBuilder = Json.createObjectBuilder();

    variables.forEach((k, v) -> {
        // Other types to process here
        if (v instanceof String) {
            varBuilder.add(k, (String) v);
        } else if (v instanceof Integer) {
            varBuilder.add(k, (Integer) v);
        }
    });

    return varBuilder.build();
}

Why only String and Integer why can not I keep maps in variables? JsonBuilderFactory can create nested objects as well.

[hogmuzzle]

I changed to

private JsonObject _formatJsonVariables() {
        JsonObjectBuilder varBuilder = Json.createObjectBuilder();

        variables.forEach((k, v) -> {
            // Other types to process here
            if (v instanceof String) {
                varBuilder.add(k, (String) v);
            } else if (v instanceof Integer) {
                varBuilder.add(k, (Integer) v);
            } else {
                try(Jsonb jsonb = JsonbBuilder.create()) {
                    JsonStructure str = ((JsonBinding)jsonb).toJsonStructure(v);
                    varBuilder.add(k, str);

                } catch (Exception ignore) {}
            }
        });

        return varBuilder.build();
    }

[t1]

It would be cool if you could create a PR for this! If you are not sure about how to do that, just ask.

[jmartisk]

+1 for a PR. Just a few comments:

• Maybe we should also allow the user to pass a JsonValue directly if they prefer? so,

} else if (v instanceof JsonValue) {
   varBuilder.add(k, (JsonValue)v);
}

• Adding a small test into io.smallrye.graphql.tests.client.dynamic.DynamicClientTest would be cool too! Similar to testQueryWithVars, just a bit more complex)

[hogmuzzle]

How can I create a PR? I cloned the repo and made modifications to code and tests but when I try to push my changes to a new branch I get an 403 error.

[phillip-kruger]

You can make modifications in your own fork, and then open a PR from there.

[t1]

The documentation in GitHub is actually very good. Maybe this page is what you need.

[jmartisk]

done in #996