Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jwt-auth modularization before 3.0.0 release #332

Closed
sberyozkin opened this issue Nov 24, 2020 · 1 comment
Closed

Improve jwt-auth modularization before 3.0.0 release #332

sberyozkin opened this issue Nov 24, 2020 · 1 comment
Milestone

Comments

@sberyozkin
Copy link
Contributor

sberyozkin commented Nov 24, 2020

The old implementation module has just been split on the master branch into common , jwt-build and jwt-auth (which is effectively the old implementation minus the common utility and JWT builder API).
jwt-auth still depends on jwt-build to keep the existing expectations and it also ships the JAX-RS code which is not used by all the integrators.
The proposal is to modularize jwt-auth further before 3.0.0 (MP JWT 1.2) is released :

  • move the JAX-RS code into a new jwt-jaxrs module which will depend on jwt-auth
  • drop smallrye-jwt-build dependency and let users add it if it is needed (though if we can expect the builder API be eventually standardized then perhaps it would be better to keep this dependency but the users can now easily exclude it if they don't use the builder API - this looks like a better option - otheriwise if we drop it now and then decide to add back then it would be a bit of a mess :-) )
@sberyozkin sberyozkin added this to the 3.0.0 milestone Nov 24, 2020
@sberyozkin
Copy link
Contributor Author

@radcortez FYI, I'm planning to fix this issue before 3.0.0 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant