Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration key location inconsistency #395

Closed
huw0 opened this issue Jan 23, 2021 · 2 comments · Fixed by #405
Closed

Fix configuration key location inconsistency #395

huw0 opened this issue Jan 23, 2021 · 2 comments · Fixed by #405
Milestone

Comments

@huw0
Copy link

huw0 commented Jan 23, 2021

smallrye.jwt.encrypt.key-location
smallrye.jwt.sign.key-location
smallrye.jwt.verify.key.location
mp.jwt.verify.publickey.location

Configuration keys with dashes should be replaced with dots, making them all consistent and ensuring that smallrye is consistent with microprofile convention.

Probably I'm not the first person who has copied and modified the verify configuration and then spent some time debugging why the sign config appears to be unset.

Probably desirable to support old config keys for awhile to prevent breaking backwards compatibility.

@sberyozkin
Copy link
Contributor

I agree, I think I recorded this task somewhere, may be in the current MP JWT PR (which will need to be refreshed in due time).
We can do it for 3.0.0 Final I guess

@sberyozkin sberyozkin modified the milestones: 3.0.0, 2.4.3 Jan 24, 2021
@sberyozkin
Copy link
Contributor

I'll deprecate it in 2.4.x so that we can drop the old properties in 3.0.0 final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants