From bb5eb784378e1bd4224d5aad7e87b065072190f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Szynkiewicz?= Date: Tue, 29 Mar 2022 14:32:05 +0200 Subject: [PATCH] build javadoc in java 17 PR job --- .github/workflows/build.yml | 4 ++-- api/src/main/java/io/smallrye/stork/api/ServiceInstance.java | 2 +- .../smallrye/stork/impl/ServiceInstanceWithStatGathering.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 99d78b4e..bf6764ed 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,7 +26,7 @@ jobs: java: [ { 'version': '11', opts: '' }, { 'version': '16', 'opts': '' }, - { 'version': '17', 'opts': '' } + { 'version': '17', 'opts': 'javadoc:javadoc' } ] name: build with jdk ${{matrix.java.version}} @@ -42,7 +42,7 @@ jobs: cache: maven - name: build with maven - run: mvn -B formatter:validate verify --file pom.xml + run: mvn -B formatter:validate verify --file pom.xml ${{matrix.java.opts}} build-windows: runs-on: windows-latest diff --git a/api/src/main/java/io/smallrye/stork/api/ServiceInstance.java b/api/src/main/java/io/smallrye/stork/api/ServiceInstance.java index bf2d6f91..4033434c 100644 --- a/api/src/main/java/io/smallrye/stork/api/ServiceInstance.java +++ b/api/src/main/java/io/smallrye/stork/api/ServiceInstance.java @@ -51,7 +51,7 @@ default boolean gatherStatistics() { } /** - *

Warning

Usually should not be called directly. + * Warning Usually should not be called directly. * Most client libraries should use {@link Service#selectInstanceAndRecordStart(Collection, boolean)} and * {@link Service#selectInstanceAndRecordStart(boolean)} * to select services. These methods invoke this method automatically diff --git a/core/src/main/java/io/smallrye/stork/impl/ServiceInstanceWithStatGathering.java b/core/src/main/java/io/smallrye/stork/impl/ServiceInstanceWithStatGathering.java index 27fe0444..7a915d33 100644 --- a/core/src/main/java/io/smallrye/stork/impl/ServiceInstanceWithStatGathering.java +++ b/core/src/main/java/io/smallrye/stork/impl/ServiceInstanceWithStatGathering.java @@ -58,7 +58,7 @@ public void recordEnd(Throwable failure) { } /** - *

Do not use for production code

+ * Do not use for production code * * mock recording time for tests *