From d2a823372a48a8df56c94cff5301ec3d46a2622c Mon Sep 17 00:00:00 2001 From: Josh Drake Date: Fri, 30 Aug 2024 13:21:05 -0500 Subject: [PATCH] Remove extraneous 'CertFreeCertificateContext' in capi. --- kms/capi/capi.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kms/capi/capi.go b/kms/capi/capi.go index 3acb47dc..d4caa6fd 100644 --- a/kms/capi/capi.go +++ b/kms/capi/capi.go @@ -791,7 +791,6 @@ func (k *CAPIKMS) DeleteCertificate(req *apiv1.DeleteCertificateRequest) error { if certHandle == nil { return nil } - defer windows.CertFreeCertificateContext(certHandle) if err := windows.CertDeleteCertificateFromStore(certHandle); err != nil { return fmt.Errorf("failed removing certificate: %w", err) @@ -822,7 +821,6 @@ func (k *CAPIKMS) DeleteCertificate(req *apiv1.DeleteCertificateRequest) error { if certHandle == nil { return nil } - defer windows.CertFreeCertificateContext(certHandle) if err := windows.CertDeleteCertificateFromStore(certHandle); err != nil { return fmt.Errorf("failed removing certificate: %w", err) @@ -862,10 +860,10 @@ func (k *CAPIKMS) DeleteCertificate(req *apiv1.DeleteCertificateRequest) error { if certHandle == nil { return nil } - defer windows.CertFreeCertificateContext(certHandle) x509Cert, err := certContextToX509(certHandle) if err != nil { + defer windows.CertFreeCertificateContext(certHandle) return fmt.Errorf("could not unmarshal certificate to DER: %w", err) }