Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix xpSourceListAppend #114

Closed
smanders opened this issue Oct 10, 2016 · 3 comments
Closed

fix xpSourceListAppend #114

smanders opened this issue Oct 10, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@smanders
Copy link
Owner

smanders commented Oct 10, 2016

the enhancements made to xpSourceListAppend #101 introduced an issue for projects that use this function but aren't in a git repo when they're built
(palam, built via internpro)

the repoFiles list is empty and there's a cmake error: list sub-command REMOVE_ITEM requires list to be present.
https://github.com/smanders/externpro/blob/16.09.1/modules/xpfunmac.cmake#L863
because all of the files are untracked and have been removed from the list

@smanders smanders added the bug label Oct 10, 2016
@smanders smanders added this to the current milestone Oct 10, 2016
@smanders smanders mentioned this issue Oct 10, 2016
66 tasks
@smanders
Copy link
Owner Author

solution: put a lot of the xpSourceListAppend() enhancements inside a

if(EXISTS ${CMAKE_SOURCE_DIR}/.git)

conditional (check to see that it's a git repo)

@smanders smanders self-assigned this Oct 17, 2016
@smanders
Copy link
Owner Author

completed with commit to dev branch

@smanders
Copy link
Owner Author

also, removed obsolete cmake function xpGenerateCscopeDb() (made obsolete by the xpSourceListAppend() enhancements) with commit to dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant