Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of union fixtures in the engine and remove the associated warning #111

Closed
smarie opened this issue Jul 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@smarie
Copy link
Owner

smarie commented Jul 9, 2020

Currently an annoying warning is issued when fixture unions are used ("WARNING the new order is not taken into account !!").

This is due to the fact that we keep in memory all the tree built during creation of the alternate fixture closures. But this tree is actually not useful anymore after construction: we should flatten it into a list of alternate closures (one per tree leaf).

Once we do this, the rest of the plugin code can be simplified greatly and the reordering can be done easily on each sub-closure (by only taking into account the relevant names for this sub-closure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant