Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fixup commits #16

Open
aschmolck opened this issue Jul 14, 2017 · 2 comments
Open

Handle fixup commits #16

aschmolck opened this issue Jul 14, 2017 · 2 comments

Comments

@aschmolck
Copy link
Contributor

Marge should probably squash fixup commits automatically.

@jcpetruzza
Copy link
Contributor

The problem here is going to be this GitLab feature: every time you push a fixup! commit, GitLab marks the merge request as WIP. So that by the time you assign it to marge, she will refuse to merge it since it is a WIP branch.

In principle marge-bot could try to reset the WIP status, but in general I'd feel uncomfortable with this. Ideally GitLab should automatically unset the WIP status once all the commits that lead to the WIP status are gone. Then, just merging the rebased version will work.

@aschmolck
Copy link
Contributor Author

Gitlab setting wip status in the presence of fixups is maybe understandable (although, why not just auto-fix them on merge?), but if the status persists beyond the existence of the fixup commits themselves (as I assume you found out on testing), we hopefully can convince them to change that. I'm comfortable resetting WIP status if we gate the whole auto-squashing thing behind a feature flag though (and make it very clear that this entails resetting WIP status).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants