Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the git ssh command #235

Closed
aclemons opened this issue Oct 31, 2019 · 6 comments
Closed

Allow configuring the git ssh command #235

aclemons opened this issue Oct 31, 2019 · 6 comments

Comments

@aclemons
Copy link
Contributor

I need to configure the git ssh command to be git-ssh-proxy in an enviroment. Could we make GIT_SSH_COMMAND configurable for this?

@aclemons
Copy link
Contributor Author

I've opened a PR with a possible solution.

@RobertKirk
Copy link
Contributor

Why do you need the git ssh command to be a different command?

@aclemons
Copy link
Contributor Author

In our environment, we need need to use a proxy. Something like:

/usr/bin/ssh -o ProxyCommand='nc -X connect -x gateway:8080 %h %p' -o StrictHostKeyChecking=no

@RobertKirk
Copy link
Contributor

If you want to add the option (which I'm not against, as we don't allow configuring the ssh command currently), could you add it to all the other places that configuration options can be set? off the top of my head

  • documentation (just the README.md I think)
  • marge/app.py for passing in configuration on the command line
    • You'll then need to pass the configuration through to the RepoManager and then to Repo so that the option is overwridden in the Repo.git command.

It'd be good to write a test as well.

@matthiasbalke
Copy link
Contributor

Maybe cloning using HTTPS (#283) is a valid alternative for you @aclemons

@aclemons
Copy link
Contributor Author

Closing this, since I no longer need it and it seems no one else does either. Feel free to re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants