Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make retries configurable #107

Closed
smarr opened this issue Mar 6, 2019 · 2 comments
Closed

Make retries configurable #107

smarr opened this issue Mar 6, 2019 · 2 comments
Labels
Feature
Milestone
v1.0 - Foundation

Comments

@smarr
Copy link
Owner

smarr commented Mar 6, 2019

Currently, we do 3 retries when a benchmark fails.
This is really useful for racy implementations.

Though, it's just a time waster for most predictable sequential benchmarks.

The number of retries be an option in the configuration file, and as a command line parameter.
@smarr smarr added the Feature label Mar 6, 2019
@smarr smarr added this to the v1.0 - Foundation milestone Mar 6, 2019
@smarr
Copy link
Owner Author

smarr commented Mar 6, 2019

I decided against making it a command-line parameter, in the interest of having a complete documentation of the experiments.

@smarr smarr mentioned this issue Mar 6, 2019
Merged
@smarr
Copy link
Owner Author

smarr commented Mar 6, 2019

Implemented with #108.

@smarr smarr closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
Usability
Status: Done
Milestone
v1.0 - Foundation
Development

No branches or pull requests
1 participant
@smarr