increase solhint #53280
RensRsolidity.yml
on: push
Detect changes
6s
Prepublish Test
1m 30s
Native Compilation
4m 11s
Solidity Lint
38s
Prettier Formatting
52s
Annotations
1 error and 25 warnings
|
Solidity Lint
Got error Error: No job for job name: "Lint" found during self-lookup, invalid job name given?
Available jobs names + ids: Detect changes|21528388584,Solidity Lint|21528399486,Prettier Formatting|21528399756,Prepublish Test|21528399980,Native Compilation|21528400194
, failing action
|
|
Detect changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Solidity Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Solidity Lint:
contracts/test/v0.8/Cron.test.ts#L43
'libType' is never reassigned. Use 'const' instead
|
|
Solidity Lint:
contracts/test/v0.8/KeeperRegistrar.test.ts#L37
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
|
|
Solidity Lint:
contracts/test/v0.8/VRFSubscriptionBalanceMonitor.test.ts#L282
'tx' is never reassigned. Use 'const' instead
|
|
Solidity Lint:
contracts/test/v0.8/automation/ERC20BalanceMonitor.test.ts#L276
'tx' is never reassigned. Use 'const' instead
|
|
Solidity Lint:
contracts/test/v0.8/automation/EthBalanceMonitor.test.ts#L267
'tx' is never reassigned. Use 'const' instead
|
|
Solidity Lint:
contracts/test/v0.8/automation/KeeperRegistrar2_0.test.ts#L40
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
|
|
Solidity Lint:
contracts/test/v0.8/automation/KeeperRegistrar2_0.test.ts#L42
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
|
|
Solidity Lint:
contracts/test/v0.8/automation/KeeperRegistrar2_0.test.ts#L46
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
|
|
Solidity Lint:
contracts/test/v0.8/automation/KeeperRegistry1_2.test.ts#L77
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
|
|
Solidity Lint:
contracts/test/v0.8/automation/KeeperRegistry1_2.test.ts#L1094
'maxPayment' is never reassigned. Use 'const' instead
|
|
Solidity Lint
Fallback should be external and payable to accept native currency
|
|
Solidity Lint
Constant variable c_feedParamKey is not in all caps, it should be C_FEEDPARAMKEY
|
|
Solidity Lint
Explicitly mark visibility of state
|
|
Solidity Lint
Constant variable c_timeParamKey is not in all caps, it should be C_TIMEPARAMKEY
|
|
Solidity Lint
Explicitly mark visibility of state
|
|
Solidity Lint
Constant variable scale is not in all caps, it should be SCALE
|
|
Solidity Lint
Explicitly mark visibility of state
|
|
Solidity Lint
Internal function getReport is not prefixed with underscore (_)
|
|
Solidity Lint
Internal function bytes32ToHexString is not prefixed with underscore (_)
|
|
Solidity Lint
Internal function updateFeed is not prefixed with underscore (_)
|
|
Prettier Formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Prepublish Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Native Compilation
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|