bumg golangci-lint 1.54.2 #10265
Merged
bumg golangci-lint 1.54.2 #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
patrickhuie19
previously approved these changes
Aug 20, 2023
ilija42
previously approved these changes
Aug 21, 2023
jmank88
force-pushed
the
golangci-lint-1.54.1
branch
from
46ee945
to
9e1eb67
Compare
jmank88
force-pushed
the
golangci-lint-1.54.1
branch
from
9e1eb67
to
ea38146
Compare
|
Updated to 1.54.2 and moved the QoL commit over to #10312 to avoid being blocked on this failing check. |
|
typecheck is still broken in 1.54.2 Edit: This appears to be resolved now, so must not have been strictly due to that checker 🤷 |
jmank88
force-pushed
the
golangci-lint-1.54.1
branch
2 times, most recently
from
7c45ed7
to
ba1f275
Compare
jmank88
force-pushed
the
golangci-lint-1.54.1
branch
from
ba1f275
to
3fc10f3
Compare
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6133133652 |
jmank88
requested review from
a team,
chainchad,
javuto,
jkongie and
samsondav
as code owners
|
SonarQube Quality Gate
|
chudilka1
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade is producing a lot of false positives from(typecheck)- we may have to wait for a fix.Resolved itself - perhaps via dependency bump.